[torquedev] Five patches for torque-2.3.0-snap.200802281931

[Eygene Ryabinkin]

Garrick, good day.

Wed, Mar 05, 2008 at 12:07:47PM -0800, Garrick Staples wrote:
> On Wed, Mar 05, 2008 at 04:48:02PM +0300, Eygene Ryabinkin alleged:
> > 
> > Tue, Mar 04, 2008 at 11:13:41AM -0800, Garrick Staples wrote:
> > > > What I have instead of the first patch is the double quotes escaping
> > > > patch for the configure.ac.  I happened to specify arguments with
> > > > double quotes and C compiler was not happy.
> > > 
> > > For my own testing, what was the arg that broke it?
> > 
> > By accident I typed './configure --with-server_home=\"server.fqdn\"'.
> 
> I still get a syntax error even with your changes.
> 
> ../../../trunk/src/cmds/qstat.c: In function `tcl_init':
> ../../../trunk/src/cmds/qstat.c:1729: error: syntax error before "server"

And may I look at your configure script?  I assume that you
reconstructed new configure from configure.ac?

> > So, it is not something that breaks existing configure invocations.
> > But if there will be legal arguments with quotes inside, Torque
> > will not compile, so it may be wise to fix it now and don't have
> > worries later: the fix itself should not broke anything.
> 
> Having quotes leads to eventual brokeness anyways.  Working to let it compile
> just delays the onset of pain.  
> 
> If you feed it bad options, it *should* fail to compile.  I'm now tempted to
> add configure checks to reject values with quotes.

May be it will be good.

> > Moreover, some OSes can have quotes in their default CFLAGS value,
> > so this will also broke compilation due to the bad value of PBS_CFLAGS
> > in src/include/pbs_config.h.
> 
> I've never seen an OS with a default CFLAGS value.

There are many: FreeBSD, possibly Net/OpenBSD.  RPM compilation on
CentOS 5 adds default flags.  Possibly there are other cases.
-- 
Eygene Ryabinkin, Russian Research Centre "Kurchatov Institute"