[torquedev] PBS Server not closing inherited files
Josh Butikofer
josh at clusterresources.com
Wed Dec 5 15:22:03 MST 2007
Garrick,
So traditionally we do not add fixes to 2.2 and then merge them into the trunk? And we do the back
porting by hand? I think there is some confusion on our part since we are used to using merges with
other repositories at CRI.
--
Joshua Butikofer
Cluster Resources, Inc.
josh at clusterresources.com
Voice: (801) 717-3707
Fax: (801) 717-3738
--------------------------
Garrick Staples wrote:
> On Wed, Dec 05, 2007 at 10:42:18AM -0700, Steve Snelgrove alleged:
>> I found a small bug in the PBS Server code in pbsd_init where
>> the sense of a compare was backwards. The effect was that
>> the close inherited files loop never ran. This is probably not
>> a big deal but should probably still be fixed.
>>
>> In trying to correct this, I noticed that just changing the compare
>> did not work because prior to calling pbsd_init, main had already
>> opened the log file. So this loop needs to be moved out to main.
>>
>> The changes are shown below. Should I go ahead and make this
>> correction?
>>
>>
>>
>> ssnelgrove at makua:~/torque/2.2-fixes/src/server$ svn diff
>
> Be sure you are working in 'trunk' and backport fixes from trunk to the *-fixes
> branches.
>
> I think a freebsd4 fix on 2.2-fixes that wasn't in trunk.
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> torquedev mailing list
> torquedev at supercluster.org
> http://www.supercluster.org/mailman/listinfo/torquedev
More information about the torquedev
mailing list